diff --git a/epmet-module/gov-issue/gov-issue-server/src/main/java/com/epmet/redis/IssueVoteDetailRedis.java b/epmet-module/gov-issue/gov-issue-server/src/main/java/com/epmet/redis/IssueVoteDetailRedis.java index 2ae91874d3..268ddfbf88 100644 --- a/epmet-module/gov-issue/gov-issue-server/src/main/java/com/epmet/redis/IssueVoteDetailRedis.java +++ b/epmet-module/gov-issue/gov-issue-server/src/main/java/com/epmet/redis/IssueVoteDetailRedis.java @@ -23,14 +23,12 @@ import com.epmet.commons.tools.redis.RedisUtils; import com.epmet.commons.tools.utils.Result; import com.epmet.constant.IssueConstant; import com.epmet.dto.IssueDTO; -import com.epmet.dto.IssueVoteStatisticalDTO; import com.epmet.dto.form.CommonGridIdFormDTO; import com.epmet.dto.form.VoteRedisFormDTO; -import com.epmet.entity.IssueVoteStatisticalEntity; import com.epmet.feign.ResiGroupFeignClient; import com.epmet.service.IssueService; import com.epmet.service.IssueVoteDetailService; -import com.epmet.service.IssueVoteStatisticalService; +import com.epmet.utils.ModuleConstants; import org.apache.commons.lang3.StringUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -55,9 +53,6 @@ public class IssueVoteDetailRedis { @Autowired private RedisUtils redisUtils; - @Autowired - private IssueVoteStatisticalService issueVoteStatisticalService; - @Autowired private ResiGroupFeignClient resiGroupFeignClient; @@ -166,7 +161,7 @@ public class IssueVoteDetailRedis { } }else{ //如果没有该议题,终止所有操作 - logger.warn(String.format("找不到指定Id的议题,Id:【%s】",issueId)); + logger.warn(String.format(ModuleConstants.ISSUE_NOT_FOUND_EXCEPTION_TEMPLATE,issueId)); return null; } @@ -208,7 +203,7 @@ public class IssueVoteDetailRedis { set(voteCache); return voteCache; }else{ - logger.warn(String.format("找不到指定Id的议题,Id:【%s】",issueId)); + logger.warn(String.format(ModuleConstants.ISSUE_NOT_FOUND_EXCEPTION_TEMPLATE,issueId)); return null; } } diff --git a/epmet-module/gov-issue/gov-issue-server/src/main/java/com/epmet/service/impl/IssueVoteStatisticalServiceImpl.java b/epmet-module/gov-issue/gov-issue-server/src/main/java/com/epmet/service/impl/IssueVoteStatisticalServiceImpl.java index 4bb9611e45..320138bfc5 100644 --- a/epmet-module/gov-issue/gov-issue-server/src/main/java/com/epmet/service/impl/IssueVoteStatisticalServiceImpl.java +++ b/epmet-module/gov-issue/gov-issue-server/src/main/java/com/epmet/service/impl/IssueVoteStatisticalServiceImpl.java @@ -302,7 +302,7 @@ public class IssueVoteStatisticalServiceImpl extends BaseServiceImpl> entry : summaryMap.entrySet()) { IssueVoteStatisticalDTO obj = new IssueVoteStatisticalDTO(); - obj.setCreatedBy("system"); + obj.setCreatedBy(ModuleConstants.CREATED_BY_SYSTEM); obj.setIssueId(entry.getKey()); List v = entry.getValue(); if (v.size() > NumConstant.ONE) { @@ -338,7 +338,7 @@ public class IssueVoteStatisticalServiceImpl extends BaseServiceImpl v = entry.getValue(); for(IssueDTO issue : v){ - //TODO 待删除 - Integer a = issueVoteDetailService.getVotingCount(issue.getId(),IssueConstant.SUPPORT); - //TODO 待删除 - Integer b = issueVoteDetailService.getVotingCount(issue.getId(),IssueConstant.OPPOSE); IssueVoteStatisticalDTO vote = new IssueVoteStatisticalDTO(); vote.setIssueId(issue.getId()); @@ -479,31 +475,22 @@ public class IssueVoteStatisticalServiceImpl extends BaseServiceImpl