diff --git a/esua-epdc/epdc-admin/epdc-admin-server/src/main/java/com/elink/esua/epdc/service/impl/SysDeptServiceImpl.java b/esua-epdc/epdc-admin/epdc-admin-server/src/main/java/com/elink/esua/epdc/service/impl/SysDeptServiceImpl.java index c31a7dfcd..43b55bd3a 100644 --- a/esua-epdc/epdc-admin/epdc-admin-server/src/main/java/com/elink/esua/epdc/service/impl/SysDeptServiceImpl.java +++ b/esua-epdc/epdc-admin/epdc-admin-server/src/main/java/com/elink/esua/epdc/service/impl/SysDeptServiceImpl.java @@ -569,6 +569,7 @@ public class SysDeptServiceImpl extends BaseServiceImpl> queryUserSysDeptInfo(UserSysDeptInfoFormDTO userSysDeptInfoFormDTO); - /** - * @param id - * @return com.elink.esua.epdc.commons.tools.utils.Result - * @Author yinzuomei - * @Description 根据部门id获取部门信息 - * @Date 2019/12/6 20:22 - **/ - @GetMapping("/sys/dept/{id}") - Result getSysDeptDTO(@PathVariable("id") Long id); - - - /*** - * 查询所有网格 - * @param - * @return com.elink.esua.epdc.commons.tools.utils.Result - * @author qushutong - * @date 2019/12/12 17:16 - */ - @GetMapping("/sys/dept/listAllGridId") - Result> listAllGridId(); - /** * 按部门类型,分页查询部门列表 * diff --git a/esua-epdc/epdc-module/epdc-kpi/epdc-kpi-server/src/main/java/com/elink/esua/epdc/feign/fallback/AdminFeignClientFallback.java b/esua-epdc/epdc-module/epdc-kpi/epdc-kpi-server/src/main/java/com/elink/esua/epdc/feign/fallback/AdminFeignClientFallback.java index e38fed3f1..d7ce5082e 100644 --- a/esua-epdc/epdc-module/epdc-kpi/epdc-kpi-server/src/main/java/com/elink/esua/epdc/feign/fallback/AdminFeignClientFallback.java +++ b/esua-epdc/epdc-module/epdc-kpi/epdc-kpi-server/src/main/java/com/elink/esua/epdc/feign/fallback/AdminFeignClientFallback.java @@ -32,30 +32,6 @@ public class AdminFeignClientFallback implements AdminFeignClient { return ModuleUtils.feignConError(ServiceConstant.EPDC_ADMIN_SERVER, "queryUserSysDeptInfo", userSysDeptInfoFormDTO); } - /** - * @param id - * @return com.elink.esua.epdc.commons.tools.utils.Result - * @Author yinzuomei - * @Description 根据部门id获取部门信息 - * @Date 2019/12/6 20:22 - **/ - @Override - public Result getSysDeptDTO(Long id) { - return ModuleUtils.feignConError(ServiceConstant.EPDC_ADMIN_SERVER, "getSysDeptDTO", id); - } - - /*** - * 获取所有网格 - * @param - * @return com.elink.esua.epdc.commons.tools.utils.Result> - * @author qushutong - * @date 2019/12/12 19:03 - */ - @Override - public Result> listAllGridId() { - return ModuleUtils.feignConError(ServiceConstant.EPDC_ADMIN_SERVER, "listAllGridId", ""); - } - @Override public Result> pageDeptIdByTypeKey(String typeKey, Integer pageSize, Integer pageIndex) { return ModuleUtils.feignConError(ServiceConstant.EPDC_ADMIN_SERVER, "pageDeptIdByTypeKey", typeKey, pageSize, pageIndex); diff --git a/esua-epdc/epdc-module/epdc-kpi/epdc-kpi-server/src/main/java/com/elink/esua/epdc/service/impl/KpiManualScoreServiceImpl.java b/esua-epdc/epdc-module/epdc-kpi/epdc-kpi-server/src/main/java/com/elink/esua/epdc/service/impl/KpiManualScoreServiceImpl.java index b32fa2455..6d58c6962 100644 --- a/esua-epdc/epdc-module/epdc-kpi/epdc-kpi-server/src/main/java/com/elink/esua/epdc/service/impl/KpiManualScoreServiceImpl.java +++ b/esua-epdc/epdc-module/epdc-kpi/epdc-kpi-server/src/main/java/com/elink/esua/epdc/service/impl/KpiManualScoreServiceImpl.java @@ -1,19 +1,3 @@ -/** - * Copyright 2018 人人开源 https://www.renren.io - *

- * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation, either version 3 of the License, or - * (at your option) any later version. - *

- * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - *

- * You should have received a copy of the GNU General Public License - * along with this program. If not, see . - */ package com.elink.esua.epdc.service.impl; @@ -50,6 +34,7 @@ import com.elink.esua.epdc.enums.KpiCycleEnum; import com.elink.esua.epdc.excel.KpiManualScoreTemplateExcel; import com.elink.esua.epdc.feign.AdminFeignClient; import com.elink.esua.epdc.service.KpiManualScoreService; +import com.elink.esua.epdc.utils.DeptUtils; import com.elink.esua.epdc.utils.StreamUtils; import com.google.common.collect.Lists; import org.apache.commons.lang3.StringUtils; @@ -75,15 +60,22 @@ import java.util.*; public class KpiManualScoreServiceImpl extends BaseServiceImpl implements KpiManualScoreService { private Logger logger = LoggerFactory.getLogger(getClass()); + @Autowired private KpiManualScoreRuleDao kpiManualScoreRuleDao; + @Autowired private KpiRuleDao kpiRuleDao; + @Autowired private AdminFeignClient adminFeignClient; + @Autowired private KpiResultGridDao kpiResultGridDao; + @Autowired + private DeptUtils deptUtils; + @Override public PageData page(Map params) { String ruleId = params.containsKey("ruleId") ? params.get("ruleId").toString() : null; @@ -128,7 +120,6 @@ public class KpiManualScoreServiceImpl extends BaseServiceImpl sysDeptDTOResult = adminFeignClient.getSysDeptDTO(Long.valueOf(dto.getDeptId())); - if (!sysDeptDTOResult.success()) { - return new Result().error(sysDeptDTOResult.getMsg()); - } - if (!kpiManualScoreRuleEntity.getDeptTypeKey().equals(sysDeptDTOResult.getData().getTypeKey())) { + DeptLevelAndLeaderDTO deptLevel = deptUtils.getDeptLevelInfo(dto.getDeptId(), YesOrNoEnum.YES); + + if (!kpiManualScoreRuleEntity.getDeptTypeKey().equals(deptLevel.getTypeKey())) { return new Result().error("所选部门不在当前规则考核范围内"); } @@ -422,11 +408,6 @@ public class KpiManualScoreServiceImpl extends BaseServiceImpl adminResult = adminFeignClient.getDeptInfoById(dto.getDeptId(), YesOrNoEnum.YES.value()); - if (!adminResult.success()) { - return new Result().error(adminResult.getMsg()); - } - DeptLevelAndLeaderDTO deptLevel = adminResult.getData(); dto.setAllDeptNames(deptLevel.getAllDeptNames()); dto.setAllDeptIds(deptLevel.getAllDeptIds()); dto.setParentDeptNames(deptLevel.getParentDeptNames()); @@ -435,6 +416,7 @@ public class KpiManualScoreServiceImpl extends BaseServiceImpl result = adminFeignClient.getDeptInfoById(deptId, yesOrNo.value()); + if (!result.success() || result.getData() == null) { + throw new RenException("获取机构信息失败"); + } + return result.getData(); + } +}